Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radec warnings #177

Merged
merged 5 commits into from Jun 8, 2023
Merged

Radec warnings #177

merged 5 commits into from Jun 8, 2023

Conversation

araichoor
Copy link
Contributor

This PR:

Documentation with the current version of this PR is available here: https://data.desi.lbl.gov/desi/users/raichoor/tmpdir/desidatamodel_radec_warnings/doc/v0/.

@coveralls
Copy link

coveralls commented Jun 8, 2023

Coverage Status

coverage: 100.0%. remained the same when pulling 4c3c7c9 on radec_warnings into ec332b6 on main.

Copy link
Member

@weaverba137 weaverba137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any problems with this. Free to merge when ready.

@araichoor
Copy link
Contributor Author

Thanks; I m making a final check with looking at the modified html files one by one.

@araichoor
Copy link
Contributor Author

I just pushed a commit removing the "fiber_radec pmcorr warning" for one file, as it actually doesn t contain the FIBER_{RA,DEC} columns.

I ll merge when the checks have passed.

@araichoor araichoor merged commit 1833e84 into main Jun 8, 2023
22 checks passed
@araichoor araichoor deleted the radec_warnings branch June 8, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants