emline: add warning about bugged EWs in fuji/guadalupe #181
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #180.
It mentions that the emline equivalent widths in fuji/guadalupe are wrong (overestimated) by
(1+z)**2
; and that this has been fixed in subsequent reductions (e.g. iron).It makes me think: shall I rather say "(e.g. himalayas, iron)"?
Built doc here: https://data.desi.lbl.gov/desi/users/raichoor/tmpdir/desidatamodel_emline_ew/_build/html/DESI_SPECTRO_REDUX/SPECPROD/tiles/GROUPTYPE/TILEID/GROUPID/emline-SPECTROGRAPH-TILEID-GROUPID.html
I m happy to implement any suggestion.