Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DESINAME description #189

Merged
merged 3 commits into from Feb 7, 2024
Merged

DESINAME description #189

merged 3 commits into from Feb 7, 2024

Conversation

weaverba137
Copy link
Member

This PR closes #188.

I copied @akremin's text from #188 as a placeholder, and it is a bit long, but we can change that before merging.

@weaverba137 weaverba137 self-assigned this Feb 7, 2024
@coveralls
Copy link

coveralls commented Feb 7, 2024 •
edited

Coverage Status

coverage: 100.0%. remained the same
when pulling a62f017 on add-desiname
into 746385c on main.

sbailey
sbailey approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@sbailey sbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I slightly shortened description and added a missing ]. Go ahead and merge when tests pass.

@weaverba137
Copy link
Member Author

Thank you @sbailey, merging now.

@weaverba137 weaverba137 merged commit 98a68fd into main Feb 7, 2024
34 checks passed
@weaverba137 weaverba137 deleted the add-desiname branch February 7, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbailey sbailey sbailey approved these changes

@akremin akremin Awaiting requested review from akremin

Assignees

@weaverba137 weaverba137

Labels
None yet
Projects
Jura
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DESINAME needs an entry in column descriptions
3 participants
@weaverba137 @coveralls @sbailey