Updates for 18.3 #46
Merged
Updates for 18.3 #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto updates-for-18.3 * 'updates-for-18.3' of github.com:desihub/desidatamodel: update changes.rst
…nto updates-for-18.3 * 'updates-for-18.3' of github.com:desihub/desidatamodel: add fiberflatnight file
…nto updates-for-18.3 * 'updates-for-18.3' of github.com:desihub/desidatamodel: update fiberflat file
sbailey
approved these changes
Apr 5, 2018
There was a problem hiding this comment.
Structurally this looks good, though we still need additional editing passes to fill in the "Brief Description" and "Summary the contents of this HDU" entries, e.g. in fiberflatnight. Let's merge this now and then handle other updates as separate PRs. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #45. There's a question in that issue that hasn't been addressed yet.
Also, I have removed all Python 2 support. desidatamodel is not required by any other package, so this should not be a problem.