Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ql update #48

Merged
merged 84 commits into from Jun 13, 2018
Merged

Ql update #48

merged 84 commits into from Jun 13, 2018

Conversation

Srheft
Copy link
Contributor

@Srheft Srheft commented May 29, 2018

@sbailey:
This PR updates the number, naming convention and the format of the quick look outputs.

@sbailey
Copy link
Contributor

sbailey commented May 29, 2018

If you have sphinx installed locally, you can use python setup.py build_sphinx to test syntax before pushing to github and having Travis test it. In this case, I see these errors:

/Users/sbailey/desi/git/desidatamodel/doc/QUICKLOOK/ql-mergedQA-CAMERA-EXPID.rst:71: WARNING: Inline strong start-string without end-string.
/Users/sbailey/desi/git/desidatamodel/doc/QUICKLOOK/ql-mergedQA-CAMERA-EXPID.rst:78: WARNING: Inline strong start-string without end-string.
/Users/sbailey/desi/git/desidatamodel/doc/QUICKLOOK/ql-mergedQA-CAMERA-EXPID.rst:95: WARNING: Inline strong start-string without end-string.
/Users/sbailey/desi/git/desidatamodel/doc/QUICKLOOK/ql-mergedQA-CAMERA-EXPID.rst:105: WARNING: Inline strong start-string without end-string.

It appears that ql-mergedQA-CAMERA-EXPID.rst has some non-ASCII characters in a table header. Try replacing those lines with:

======================= =================  ================ ===================================================
KEY                     Example Value      Type             Comment
======================= =================  ================ ===================================================

@Srheft
Copy link
Contributor Author

Srheft commented May 30, 2018

Thanks for the tip! fixed now.

@sbailey sbailey merged commit d7b9f47 into master Jun 13, 2018
@weaverba137 weaverba137 deleted the ql_Update branch July 24, 2018 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants