Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates for 18.6 software release #52

Merged
merged 3 commits into from Jul 19, 2018
Merged

updates for 18.6 software release #52

merged 3 commits into from Jul 19, 2018

Conversation

sbailey
Copy link
Contributor

@sbailey sbailey commented Jul 19, 2018

This PR updates the data model for the 18.6 software release, in particular:

  • raw data are now grouped under NIGHT/EXPID/ subdirectories instead of just NIGHT/ subdirectories.
  • additional HDUs, columns, and renamed HDUs of fiberassign output tile files.
  • additional placeholders (with some details) for GFA guide, focus, and sky monitor raw data.

The placeholder data model files are not yet used by the offline pipeline and may continue to evolve as part of the WBS 1.7 ICS acceptance process. After their formats have stabilized we will expand those data models.

@sbailey sbailey requested a review from weaverba137 July 19, 2018 00:02
@weaverba137
Copy link
Member

Do you have a fix for the test failures? If so, I can wait a few minutes for that.

@sbailey
Copy link
Contributor Author

sbailey commented Jul 19, 2018

I keep forgetting the desidatamodel also has unit tests in addition to build_sphinx. I just fixed the tests.

Also, fixes #51 (update fiberassign data model).

Copy link
Member

@weaverba137 weaverba137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me. Merge when the tests are finished.

@sbailey sbailey merged commit ba77490 into master Jul 19, 2018
@sbailey sbailey deleted the 18.6 branch July 19, 2018 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants