Change description of apertures in skies file header #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moustakas
reviewed
Aug 22, 2018
doc/DESI_TARGET/skies.rst
Outdated
| AP0 0.75 float size of aperture sunk at sky location [arcsec] | ||
| AP1 1.0 float size of aperture sunk at sky location [arcsec] | ||
| AP0 0.75 float radius of aperture sunk at sky location [arcsec] | ||
| AP1 1.0 float radius of aperture sunk at sky location [arcsec] | ||
| BADFLUX0 1000.0 float amount of flux in AP0 to define a BAD sky location |
There was a problem hiding this comment.
I had to read this a couple times to understand what an "aperture sunk" was! Should also specify the units of BADFLUX (nanomaggies).
There was a problem hiding this comment.
Fixed in b97def9.
@moustakas: If this looks good now, please merge.
weaverba137
reviewed
Aug 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe apertures as "radii" not sizes. Also deprecate data model for files that are no longer in use to fix #58.