Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggested updates for documenting all cameras #75

Merged
merged 2 commits into from Apr 4, 2019

Conversation

sbailey
Copy link
Contributor

@sbailey sbailey commented Apr 4, 2019

Rather than try to describe in English my suggested changes to branch spectrograph-tests before merging PR #73, here is a PR to that branch with suggested changes to document all cameras. I recognize that this might cause the validator to generate a bunch of warnings about missing HDUs, but ok.

@weaverba137
Copy link
Member

Looks fine to me. Are you going to comment on the per-keyword problems I noted? And other stuff in the Problems section?

as long as it doesn't outright crash from me getting the doc syntax wrong.

Well, looks like it's crashing because the doc syntax is wrong. Just a minor table formatting problem.

@sbailey
Copy link
Contributor Author

sbailey commented Apr 4, 2019

I fixed the table whitespace problem.

Let's address the other per-keyword problems in separate discussions, and leave those notes in this PR as is and merge. i.e. they aren't issues with the datamodel documentation itself, but rather issues with what we want the data format to be, which requires iterations and code updates with Klaus.

@weaverba137 weaverba137 merged commit e13b63a into spectrograph-tests Apr 4, 2019
@weaverba137 weaverba137 deleted the spectrograph-tests-allcams branch April 4, 2019 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants