Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update raw data model #94

Merged
merged 12 commits into from Jan 20, 2022
Merged

Update raw data model #94

merged 12 commits into from Jan 20, 2022

Conversation

weaverba137
Copy link
Member

@weaverba137 weaverba137 commented Jan 14, 2022

This PR closes #92.

So far I have created placeholder files for all raw data FITS files based on 2022-01 files. A few of the files need to be merged with their older versions. I'm opening this PR to get a discussion going on these files.

Help Wanted in filling in the top level summaries in some cases, describing HDUs, and checking that older data model files can be merged with more modern descriptions.

There are four files that need to be merged:

  • desi-EXPID.rst and desi.rst
  • focus-EXPID.rst and focus.rst
  • guide-EXPID.rst and guide.rst
  • sky-EXPID.rst and sky.rst

In all cases the -EXPID.rst version represents the model from several years ago, while the "bare" version is based on contemporary files.

@weaverba137 weaverba137 added the WIP Work in Progress label Jan 14, 2022
@weaverba137 weaverba137 self-assigned this Jan 14, 2022
@coveralls
Copy link

coveralls commented Jan 14, 2022

Coverage Status

Coverage remained the same at 96.412% when pulling 118c7cf on update-raw-data into d7159e3 on main.

@weaverba137
Copy link
Member Author

The desi-EXPID.rst file turned out to be relatively easy to merge. I'll likely need some expert help with other files.

@weaverba137 weaverba137 removed the WIP Work in Progress label Jan 19, 2022
@weaverba137
Copy link
Member Author

@sbailey, I've merged the other files. Ready for review.

@weaverba137 weaverba137 changed the title [WIP] Update raw data model Update raw data model Jan 19, 2022
@weaverba137 weaverba137 merged commit b0e88e8 into main Jan 20, 2022
@weaverba137 weaverba137 deleted the update-raw-data branch January 20, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update model for DESI_SPECTRO_DATA
2 participants