patch pseudo metrology for GUIDE3 and GUIDE7 into fp-metrology.csv #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It should not change the results but the internal values of x_gfa,y_gfa of the CCD corners in write_guide3_guide7 are not actually CCD pixel coordinates (because of a mix between focal surface coordinates of the images of stars, and coordinates of CCD corners which are not on the focal surface; discussion continued offline). |
added 2 commits
July 27, 2020 17:04
…tween coordinates on physical CCD versus focal surface; GUIDE3/GUIDE7 metrology values changed by well under 1 micron
|
@julienguy I updated my methodology to take into account your recommended transformation between coordinates on the focal surface and the physical CCD. The resulting GUIDE3/GUIDE7 'metrology' values are changed by substantially less than 1 micron in all cases. |
|
thank you aaron |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes code and files that patch in Gaia-based pseudo metrology for GUIDE3 and GUIDE7.