-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Identify requests #137
Identify requests #137
Conversation
also includes some additional implementation (not yet complete) of identify_requests()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add (to the github conversation) an example I could run at beyonce or desicleanroom2 so I can test the new functionalities?
|
Thanks. I verified I can run this at nersc. So I am going to merge, but I have one comment: is there a metric that would allow us to detect an actual collision? The max error on this example is 100um, but it's not clear if it's due to a poor blind move accuracy or some friction or collision. |
Thanks. I do not have any quantitative metric, that would say a 100 um error was or was not a "glancing" collision. It's about 3x RMS error. Sort of a gray area as to whether it's a collision or something else. One would be tempted to just run 100 targets with restricted patrol radius, but that isn't exactly comparable. Because the errors should be magnified with both arms extended. What I can do is run my new |
I would be delighted if you would like to try out |
Code now distinguishes "TRACKED" targets from "REQUESTED".
TRACKED:
These are errors calculated with respect to POS_T, POS_P. They show whether we have control over the robots.
REQUESTED:
Code now parses MOVE_CMD field, and identifies the requested targets from the caller. Due to anticollision, travel limits, and enabled/disabled state, the petal of course has the right to refuse some of these targets. Hence REQUESTED will vary from TRACKED in these cases. Errors calculated with respect to REQUESTED show us how well we are getting fibers to desired locations / whether our desired locations are possible.