Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Posparams fit #85

Merged
merged 12 commits into from
Jun 4, 2020
Merged

Posparams fit #85

merged 12 commits into from
Jun 4, 2020

Conversation

julienguy
Copy link
Collaborator

  • Modest improvement in the initialization of the positioner fit by fitting first circles for all unique values of POS_P (with at least 3 points) to get a first estimate of OFFSET_X and OFFSET_Y independently of any other calibration parameter. The changes are in posparams/fitter.py. Also add in fithandler.py the catch of a ValueError exception thrown by the circle fit when it fails. One may want to change this handling of errors.
  • New function robust_fit_circle that discards outliers and starts with medians.
  • Add minor options to scripts get_posmov_calib plot_positioner plot_posmove.

@julienguy julienguy requested a review from joesilber May 30, 2020 00:16
@joesilber
Copy link
Contributor

ok by me

@julienguy julienguy merged commit d4bc9e5 into master Jun 4, 2020
@julienguy julienguy deleted the posparams_fit branch June 4, 2020 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joesilber joesilber Awaiting requested review from joesilber

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@julienguy @joesilber