When loading the plate scale, also read a new column for the S(R) arc length. #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sbailey , any objections to merging this small change? The compatible platescale data file is already in svn. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a small change to the load_platescale() function which also loads a newly added column of the arc length data S(R) from DESI-0530.
This PR does not change the actual XY <--> RS conversion routines. However, once this column is loaded, it opens up the door to using that S(R) data for the interpolation.
There is in-progress fiberassign work that needs access to this arc length data, which is the motivation for adding it to the platescale.txt file and for reading it here.
Note that this PR requires current trunk of desimodel data svn (revision >= 129389), so should not be merged until we are ok with that requirement.