adding fastfiberacceptance originally in specsim #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good but can you update doc/changes.rst? |
|
I think this is ready to merge now. Does anyone else want to weigh in? @sbailey @weaverba137 |
|
Looks fine to me. However, it looks like unit tests are no longer running. Who is responsible for getting desimodel working on GitHub Actions? |
|
Tests pass elsewhere. Nominally porting desimodel is on me, but if someone else beats me to it that would be great. Merging now because the specsim PR was already merged, breaking consistency. Ideally this should have been merged first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving fastfiberacceptance from specsim to desimodel in order to use this function in desispec for the flux calibration.