fix tiles2pix docstring and allow TILERA,TILEDEC #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corrects the docstring for
desimodel.footprint.tiles2pix(it takes a tiles table, not an array of tileids like tileids2pix). It also adds support for TILERA, TILEDEC columns instead of RA, DEC, and adds support for dictionary-like input. New tests confirm RA,DEC vs. TILERA,TILEDEC, and support for numpy structured arrays, astropy Tables, and dictionary inputs.This would be convenient but not strictly necessary to use for Fuji healpix bookkeeping. I'll self merge when needed if I don't get comments.
Note: the desimodel tiles file is deprecated and very out of date; I didn't try to remove that in this PR so that I don't accidentally break something else, but the intended usage here is to pass in a new tiles table, e.g. the tiles that are included in a production run, or one of the tiles tables in svn surveyops/ops .