Update KPNO sync scripts to use the default software stack #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to the desimodel data svn checkout. This ensures a clean starting point for the script inputs.
schlafly
approved these changes
Mar 15, 2023
There was a problem hiding this comment.
Looks good to me, thanks Ted. If it's straightforward in the existing environment, our past failures occurred when loading the hardware in fiberassign. i.e.,
from fiberassign.hardware import load_hardware
hw = load_hardware()
That would be a nice additional check to add before doing an svn commit, so that we would catch this if it reoccurs before committing a broken file to the repository. Note that we'd have to point DESIMODEL to the temporary fp sync checkout so that fiberassign looks in the right place, etc..
|
Good idea @schlafly , and DESIMODEL is already pointed at the dedicated svn checkout during the sync. |
…ded before committing result
|
For future reference, a link to discussion on DESI slack about this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the focalplane sync scripts to use the new
defaultsymlink to get the software stack to load.