Update high-level desimodel sync scripts used by cron jobs. #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add missing '-f' module swap option - Change import test to use import from fiberassign which will properly fail if exclusion polygons are not found. - Update the "force" version of the sync script which calls the desi_sync_focalplane with the --reset option. This script now has all the matching improvements in the cron version of the script.
|
The unit tests seem to fail with an unrelated issue. And in fact it looks related the the commit made 5 months ago which also failed tests... |
|
Please can you all take Michael's email off your distribution list? Thanks
Susan Lea
…On Sun, Mar 3, 2024, 3:10 PM Theodore Kisner ***@***.***> wrote:
The unit tests seem to fail with an unrelated issue. And in fact it looks related
the the commit made 5 months
<22e13f2>
ago which also failed tests...
—
Reply to this email directly, view it on GitHub
<#171 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACLFEFYU26KBGOSNGJELMRTYWOUV7AVCNFSM6AAAAABEEIYQIGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZVGM4TCNBUGI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
This looks good to me. Please go ahead and merge & install on KPNO at your convenience. Susan, I don't have permission to remove Michael's email; I am following up with admins to try to do this. Sorry for the trouble! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing '-f' module swap option
Change import test to use import from fiberassign which will properly fail if exclusion polygons are not found.
Update the "force" version of the sync script which calls the desi_sync_focalplane with the --reset option. This script now has all the matching improvements in the cron version of the script.