Fix quickquasars targetid truth #457
Conversation
py/desisim/scripts/quickquasars.py
Outdated
| _meta['TARGETID'] = metadata['MOCKID'] | ||
| _qsometa['TARGETID'] = metadata['MOCKID'] | ||
| _meta['TARGETID'][:] = metadata['MOCKID'] | ||
| _qsometa['TARGETID'][:] = metadata['MOCKID'] |
There was a problem hiding this comment.
Those two lines are what fixes the original bug?
There was a problem hiding this comment.
Yes, it is. Plus some other for DLA and BAL.
|
@alxogm, could you review again? I made some changes since the Lorentz smoothing was not stored in the truth file. |
|
@andreufont and @alxogm, here is a summary of this PR.
Do you both agree with these changes? |
|
@londumas I'm only worried that we have been using TRUEZ and we'll get confused by changing to Z_INPUT. But I don't really know what is the most informative name, so I leave it to you and @andreufont to decide |
|
@alxogm, is |
|
I have no issue with changing back |
There was a problem hiding this comment.
@alxogm, is
TRUEZused by anyone for the moment?
I think more recently by Luz, that is analyzing the BALs. I think Rodrigo and Andrea also uses it, and I do. At least. Of course we can adapt. But I think, we are getting confused with names. So I think we should have
'Z_NORSD': comes from transmission file and goes into truth file
'DZ_FOG': delta z contribution of the Finger-Of-God
'TRUEZ ': (Includes RSD and FOG) and goes into truth file.
This way we have replaced Z_noFOG by the DZ_FOG information.
I think it is clear that TRUEZ does not includes statistical or systematic shifts. You are also adding
'DZ_SYS': delta z contribution of the systematic shift
'DZ_STAT': delta z contribution of the statistic shift (Lorentzian)
And finally
'Z': Final redshift including RSD, FOG, and all shifts, that goes into the zbest file. Name is OK here.
py/desisim/scripts/quickquasars.py
Outdated
| ##Adedd to write the truth file, includen metadata for DLA's and BALs | ||
| ### Add a shift to the redshift, simulating the statistic imprecision of redrock | ||
| if args.gamma_kms_zfit: | ||
| log.info("Added zfit error with sigma {} to zbest".format(args.gamma_kms_zfit)) |
There was a problem hiding this comment.
"Added zfit error with sigma {} to zbest" please change sigma to gamma .
|
@alxogm, ok I understand better. I made the corrections. |
Fix issue #456:
- Correct the TARGETID of truth for all 4 HDUs
- Change
ztoZfor DLA