Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate desisim to GitHub Actions #546

Merged
merged 17 commits into from Feb 3, 2021
Merged

Migrate desisim to GitHub Actions #546

merged 17 commits into from Feb 3, 2021

Conversation

weaverba137
Copy link
Member

This PR migrates desisim to use GitHub Actions instead of Travis CI for unit tests.

While testing, a version of #507 reappeared, although this time it is complaining of suspiciously low ELG or LRG flux.

See this run for full details.

Oddly though, #534 did not reappear. Perhaps that was a red-herring and desimodel/branches/test-0.12 does have the fix installed.

@weaverba137 weaverba137 self-assigned this Feb 2, 2021
@sbailey
Copy link
Contributor

sbailey commented Feb 2, 2021

FYI #547 documents the pixsim test failure and likely cause (a change in specter, but requiring a non-negative input flux cut in desisim). We could proceed with this PR even if that test is still failing.

The "suspiciously low XYZ flux" problem appears occasionally in the nightly tests and previously travis tests; I usually ignore and rerun.

@weaverba137
Copy link
Member Author

weaverba137 commented Feb 2, 2021

OK, the tests were successful after a restart, but I still think the low flux problem should actually be fixed, not ignored. In particular, experts know to restart the tests (and know how to restart), but newcomers would have to be aware that this is a known issue.

@weaverba137
Copy link
Member Author

PS, I still have a few minor changes to make to this PR, like removing the .travis.yml file, so please don't merge immediately.

Copy link
Contributor

@sbailey sbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good, thanks. Merge when ready. I agree that the low flux bug should be fixed, but it doesn't need to be a blocking factor for this travis -> github actions transition.

@weaverba137
Copy link
Member Author

@sbailey, thank you merging very soon.

@weaverba137
Copy link
Member Author

Test failures are related to #507, ignoring.

@weaverba137 weaverba137 merged commit bcdc2bf into master Feb 3, 2021
@weaverba137 weaverba137 deleted the github-actions branch February 3, 2021 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants