fix negative arc line ringing #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests pass at NERSC but I'm getting the "suspiciously low ELG flux" problem every time I run now; perhaps something in numpy 1.20 triggers this more? I'm going to merge this PR since the test failures are unrelated to the fix here (fixing negative arcs). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #547 where pixsim tests were failing due to negative pixels being passed to
np.poisson(). It turns out thatdesi/spectro/templates/calib/v0.4/arc-lines-average-in-vacuum-from-winlight-20170118.fitshas some negative values in the wings of arc lines. Prior to specter commit #6a0d107,psf.projectwas clipping these negative values but now it allows you to project negative values if you really really want to so you have to fix it on the input side.The fix is simple: clip negative values from the input arc file prior to simulating.