Updated emission lines and continuum models #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxogm
requested changes
Nov 7, 2022
|
Happy to merge once Alma is happy, she know more than I do about this part of the code. I wouldn't worry too much about the "mean continuum" plot above, since the data has redshift errors that are not present in the mocks (are they?), and as we saw in Youles et al. (2022) this has an effect in the mean continuum measured by Picca. |
alxogm
approved these changes
Nov 8, 2022
|
I think you can merge @HiramHerrera |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following Pull Request updates:
BossDr9_fiducial_continuummodel dispersions based on the results found by Rodrigo in slide 6 of this presentation to reproduce eBOSS DR16 QSO dispersion found by PCA method.Emission line model, in order to better reproduce the results of PICCA Mean Flux on EDR data.
This new model also addresses the correlation between CIV Equivalent Width and Magnitude as found on observational data. Previous mocks didn't have such correlation
