Skip to content

Commit

Permalink
Merge 54dba6c into e822758
Browse files Browse the repository at this point in the history
  • Loading branch information
julienguy committed Dec 20, 2021
2 parents e822758 + 54dba6c commit 17c873d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 9 deletions.
2 changes: 1 addition & 1 deletion py/desispec/ccdcalib.py
Original file line number Diff line number Diff line change
Expand Up @@ -492,7 +492,7 @@ def compute_nightly_bias(night, cameras, outdir=None, nzeros=25, minzeros=20,
log.info(f'Nightly bias {camera}: maxabsdiff {maxabs1:.2f}, stddev {std1:.2f}')
log.info(f'Default bias {camera}: maxabsdiff {maxabs2:.2f}, stddev {std2:.2f}')

if maxabs1 < maxabs2:
if maxabs1 < maxabs2 + 0.5 : # add handicap of 0.5 elec to favor nightly bias that also fixes bad columns
log.info(f'Selecting nightly bias for {night} {camera}')
os.rename(testbias, outfile)
else:
Expand Down
9 changes: 1 addition & 8 deletions py/desispec/scripts/proc.py
Original file line number Diff line number Diff line change
Expand Up @@ -185,15 +185,8 @@ def main(args=None, comm=None):
if args.nightlybias:
timer.start('nightlybias')

bcamword = None
if rank == 0:
bcameras = [cam for cam in args.cameras if cam.lower().startswith('b')]
bcamword = parse_cameras(bcameras)

if comm is not None:
bcamword = comm.bcast(bcamword, root=0)
cmd = f"desi_compute_nightly_bias -n {args.night}"

cmd = f"desi_compute_nightly_bias -n {args.night} -c {bcamword}"
if rank == 0:
log.info(f'RUNNING {cmd}')

Expand Down

0 comments on commit 17c873d

Please sign in to comment.