Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-calculate stdstar model magnitudes #1251

Open
sbailey opened this issue Apr 20, 2021 · 1 comment
Open

pre-calculate stdstar model magnitudes #1251

sbailey opened this issue Apr 20, 2021 · 1 comment

Comments

@sbailey
Copy link
Contributor

sbailey commented Apr 20, 2021

When running stdstars super-fast on GPUs, @dmargala noted that re-calculating standard star template magnitudes every time is a significant contributor to the total stdstar runtime. These could be pre-calculated using standard filters needed by DESI (Gaia plus PHOTSYS=N/S for g,r,z) and saved in the $DESI_BASIS_TEMPLATES/stdstar_templates*.fits files themselves instead of calling desispec.scripts.stdstar.get_magnitude in desispec.scripts.stdstar.pyL521 . Note that there are other later calls to get_magnitude on the extincted flux of the selected model; this would still need to be custom.

I think this is independent of the recent work on dust, E(B-V), and Vega vs. AB but it touches similar code, so let's wait for PR #1246 and desihub/desiutil#169 before adding this optimization.

@sbailey sbailey changed the title pre-calculate stdstar model filters pre-calculate stdstar model magnitudes Apr 20, 2021
@julienguy
Copy link
Contributor

Note PR desihub/desiutil#171 (newer version 169) has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants