Spx io refactor #1039
Closed
Spx io refactor #1039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(this pull request is identical to and meant to accompany desihub/specex#35)
A major change to how specex is called by desispec, using pybind11.
Calculations performed on the same day using (i.e. with specex.py as called by desi_compute_psf_mpi)
https://github.com/desihub/desispec/tree/spx_io_refactor
and (with directions for compiling the python shared object module in subdirectory specex_pybind)
https://github.com/desihub/specex/tree/io_refactor
should produce an identical merged psf fit file to that using
https://github.com/desihub/desispec
and
https://github.com/desihub/specex
Please note this pull request is additionally dependent on branch of https://github.com/desihub/specex, as reflected in the URLs above.