Add sanity check readin the new zbest file #1335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It has no impact on the rest and solve the problem for the qn-afterburner. I tested that it gives what we expected. I directly merge it. |
|
Thanks. Please change this to be a PR to the "fiberassign_coadd" branch which has replaced "pixgroup". I branched fiberassign_coadd off of pixgroup and then rebased off of master before starting PR #1330 which is where the active work is. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the zbest HDU from the new zbest file (new run of RR) is not in the same order than previously. The TARGETID order from ZBEST HDU does not match the order from the input targetid.
I add, a sanity reorder to don't be messed with this later.
Edmond