desi_healpix_redshifts batch automation #1341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
desi_group_spectra --surveyoption to filter by survey (e.g. sv3)The relationship between desi_tile_redshifts and desi_healpix_redshifts for writing the batch script is a bit of a hack, but I need it for everest healpix so this is a fast solution. It also still requires one call per healpix/survey/program which will get unwieldy so a future update could add a wrapper for that too to loop over pix.
I confirmed that this refactor produces identical scripts for desi_tile_redshifts, while supporting the minimal features needed for desi_healpix_redshifts. I plan to self merge to be able to use tonight and postfacto comments for cleanup are welcome later...