Include TILERA,TILEDEC,MJD in TSNR2/exposures output tables #1348
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everest wrapup PR:
This PR fixes #1255 by adding TILERA,TILEDEC,MJD to the production summary exposures (formerly tsnr2) and tiles files. A side effect was to also fix more SURVEY="unknown" cases (e.g. dither tiles 80262-, now "cmx"), and fix SURVEY for tiles like 80607 (previously "cmx" because FAFLAVOR started with "cmx" even though FA_SURV="sv1"; according to https://desi.lbl.gov/trac/wiki/SurveyOps/TileDesigns those are sv1 tiles).
Example files are in /global/cfs/cdirs/desi/users/sjbailey/dev/expfiles/ sampling one night per month from December 2020 through June 2021 to get a variety of programs. The "master" files are current master branch and "new" are this branch.
Feedback requested:
For Everest we renamed the tsnr2*.fits to exposures-everest.fits since the file has outgrown the original tsnr-only usage and "exposures" is a more relevant name. However, I noticed that the EXTNAMEs are still "TSNR2_EXPID" and "TSNR2_FRAME". I suggest renaming these to "EXPOSURES" and "FRAMES", but I'm open to other suggestions.
@schlafly since you requested #1255, I'll specifically mention you for commentary. @moustakas is another friendly-expert end-user who may have opinions about HDU names.
As a reminder, EXPOSURES/TSNR2_EXPID are metrics per exposure combined across cameras, while FRAMES/TSNR2_FRAME have per-camera metrics (a "frame" is a single camera from a single expid, but I suspect that name may not be obvious to non-core-pipeline folks).
I also made a cosmetic change of preserving column order from input -> output for the FRAMES/TSNR2_FRAME table; previously astropy was alphabetically sorting the columns when creating the initial table from a list of dictionaries (probably a leftover from pre-py3.6 days when dictionary keys were returned in an undefined order).
Note: this PR is into the "everest" branch, not master yet.
For the record, the command used to generate the test files: