stdstars robust to missing individual frames #1402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akremin
approved these changes
Sep 3, 2021
There was a problem hiding this comment.
The changes look good. Adding efficiency in only having rank 0 do the selection of the files, and my tests were successful. I was able to reproduce the success of the example in the PR text. I also ran two of my own tests of zcam saturation events on April 12th. They were successful as well (including the commands below for future documentation).
export DESI_SPECTRO_REDUX=/global/cfs/cdirs/desi/users/$USER/spectro/redux
export SPECPROD=noz6
cd $DESI_SPECTRO_REDUX
copyprod --night 20210412 /global/cfs/cdirs/desi/spectro/redux/everest $SPECPROD
rm /global/cfs/cdirs/desi/users/kremin/spectro/redux/noz6/exposures/20210412/0008451[678]/stdstars-6-*.fits
desi_proc_joint_fit --traceshift --obstype science \
--cameras a67 -n 20210412 -e 84516,84517,84518
rm ${DESI_SPECTRO_REDUX}/${SPECPROD}/exposures/20210412/0008453[678]/stdstars-6-*.fits
desi_proc_joint_fit --traceshift --obstype science \
--cameras a67 -n 20210412 -e 84534,84535,84536
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1225 where multi-exposure stdstar fitting would fail if there was a single missing frame, even if other exposures from the same night had the camera.
e.g. tile 80694 on night 20210306: exposures 79570 had b8,r8,z8 but 79571 has only b8,r8 (z8 was lost due to a shutter light leak saturation event). Previously the pipeline would fail due to the missing frame-z8-00079571.fits, but with this branch it succeeds because frame-z8-00079570.fits is available for the same tile on the same night for the multi-exposure stdstar fit.
Example:
with current master:
with this branch:
Also tested:
srun -N 1 -n 2 -c 16 desi_proc_joint_fit --traceshift --obstype science --cameras a8 -n 20210306 -e 79570,79571 --mpi(i.e. the MPI logic works)