Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Averaging of PSFs with different wavelength ranges #1411

Merged
merged 1 commit into from Sep 13, 2021
Merged

Conversation

marcelo-alvarez
Copy link
Contributor

Attempt to fix bugs preventing PSF and trace coefficients from being correctly averaged in desispec.specex.mean_psf whenever the wavelength range differs between the input PSF fits:

  1. legval and legfit were not being imported from numpy.polynomial.legendre
  2. traces were being averaged redundantly for every entry in the table of PSF coefficients
  3. traces were being re-fit using the wrong number of legendre polynomial coefficients

These changes may require further validation; there is no before and after comparison possible for the use case that has changed since it was crashing for these cases (i.e. whenever the wavelength range differs between the input PSF fits).

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.002%) to 26.667% when pulling 5fabc5d on meanpsf into e767d60 on master.

Copy link
Contributor

@julienguy julienguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding those bugs.
Tested on June data.

@julienguy julienguy merged commit b533111 into master Sep 13, 2021
@marcelo-alvarez marcelo-alvarez deleted the meanpsf branch September 14, 2021 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants