Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only consider valid sky fibers #1414

Merged
merged 1 commit into from Sep 19, 2021
Merged

Only consider valid sky fibers #1414

merged 1 commit into from Sep 19, 2021

Conversation

julienguy
Copy link
Contributor

Compare the number of valid measurements per wavelength to the number of valid sky fibers (i.e. fibers that have some non null ivar values after the call to get_fiberbitmasked_frame_arrays) instead of comparing to the total number of sky fibers.
This feature caused sky subtraction to set ivar=0 to full frames. It happened in the first few nights after restart because many sky fibers have large positioning errors (>100 um).

Copy link
Member

@akremin akremin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be a check to see if np.sum(bad)==skyfibers (or equivalently nfibers==0 after it's redefined)?

I'm going to approve and merge this because it's in the right direction and I'd like it in for the pipeline tonight. But we may want to consider throwing an error if the number of sky fibers is 0.

@akremin
Copy link
Member

akremin commented Sep 19, 2021

I don't see how the Test coverage failures could be due to this simple code change. The error messages point toward issues in coveralls reporting, rather than coveralls actually reporting an issue in the desispec code.

@akremin akremin merged commit 143d1ff into master Sep 19, 2021
@akremin akremin deleted the skyfix branch September 19, 2021 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants