Set OMP_NUM_THREADS in batch script #1437
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modification to ensure that the line
export OMP_NUM_THREADS=threads_per_core
is added to automatically generated batch scripts, wherethreads_per_core
is the argument to the-c
flag in thesrun
command.Currently, this is not the case, and consequently the number of threads being used in
#pragma omp parallel
regions of compiled C++ code is currently being set to whatever the value of OMP_NUM_THREADS is when the batch script is submitted in (e.g.,OMP_NUM_THREADS=1
after runningsource /global/common/software/desi/desi_environment.sh master
on cori).Please verify that this change results in the appropriate SLURM file (with the correct
export OMP_NUM_THREADS
line) as part pipeline workflow and, if so, merge this change into master.