support astropy 5.x masked columns #1526
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates desi_qso_mgii_afterburner to support astropy 5.x which (IMHO) incorrectly interprets FITS table blank strings as masked values instead of just passing forward blank strings. This is the same issue as the fibermap reading problem in PR #1454, but here I'm just fixing the impacted column (SUBTYPE) instead of bringing in an fitsio dependency. The relevant change is:
Without this change, desi_qso_mgii_afterburner fails with:
While I'm at it, I also updated some 2-space indentation to 4-space indentation to match our code style.
Thanks for @marcelo-alvarez for the pipeline testing with updated dependencies that identified this.