New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nightqa v3 #1535
Nightqa v3 #1535
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks. I think you found a cosmic ray shower in r1. I put two minor comments in line, but ok to merge whenever you are ready.
Good you waited to merge: I've noticed that I forgot to push my last commit last night: I've just done it (0c3bad2). So I think I'm good on my side. |
This PR adds few modifications to the nightqa page creation.
The principal motivation is to move away from restricting to Main tiles only.
The chosen approach now considers all OBSTYPE="SCIENCE" exposures.
For the sframesky, tileqa, skyzfiber plots, we thus now include any SCIENCE observations.
The reason is because the type of survey should not prevent to inspect the exposures quality on those plots.
For the petalnz plot, we proceed a bit differently, as we stack the n(z) per tracer, per night.
We here:
Along the way, several changes - hopefully improvements:
I've run it on what is currently processed in $DESI_ROOT/spectro/redux/f3:
https://data.desi.lbl.gov/desi/users/raichoor/nightqa_v3_dev/f3
(though note that those files may change if I do further developments/tests for this PR)
From a quick random spot checking of those: https://data.desi.lbl.gov/desi/users/raichoor/nightqa_v3_dev/f3/20210511/dark-20210511.pdf => r1 has very funny/dubious masked pixels distribution.