Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nightly bias for all #1546

Merged
merged 2 commits into from Dec 20, 2021
Merged

Nightly bias for all #1546

merged 2 commits into from Dec 20, 2021

Conversation

julienguy
Copy link
Contributor

This PR implements (few lines changes) the proposal that we also use the nightly bias for red and nir cameras because this considerably reduces the number of 'BADCOLUMN'. Indeed most residuals in CCD columns are not due to dark current but charges generated at readout on specific pixels in the serial clock row. So we can remove them by using a recent bias.

Example from 2021/12/17 and 2021/12/18. Below are figures of the number of bad columns detected with desi_inspect_dark in the 300s dark exposure preprocessed with the default or nightly bias for the red and nir cameras.
badcolumns-20211217
badcolumns-20211218

The changes to the code simply consist in considering a nightly bias for all cameras, not just b, and to give an slight advantage in favor of the nightly bias over the default when comparing the residual levels after preprocessing (because they are very similar for the red and nir camera when the CCD are stabilized).

@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 25.64% when pulling 54dba6c on nightly-bias-for-all into e822758 on master.

@sbailey
Copy link
Contributor

sbailey commented Dec 20, 2021

Looks good; thanks for doing this check.

@sbailey sbailey merged commit 50617a3 into master Dec 20, 2021
@sbailey sbailey deleted the nightly-bias-for-all branch December 20, 2021 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants