Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements (few lines changes) the proposal that we also use the nightly bias for red and nir cameras because this considerably reduces the number of 'BADCOLUMN'. Indeed most residuals in CCD columns are not due to dark current but charges generated at readout on specific pixels in the serial clock row. So we can remove them by using a recent bias.
Example from 2021/12/17 and 2021/12/18. Below are figures of the number of bad columns detected with
desi_inspect_dark
in the 300s dark exposure preprocessed with the default or nightly bias for the red and nir cameras.The changes to the code simply consist in considering a nightly bias for all cameras, not just b, and to give an slight advantage in favor of the nightly bias over the default when comparing the residual levels after preprocessing (because they are very similar for the red and nir camera when the CCD are stabilized).