Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limit humidity model range considered #1594

Merged
merged 1 commit into from Jan 14, 2022
Merged

limit humidity model range considered #1594

merged 1 commit into from Jan 14, 2022

Conversation

sbailey
Copy link
Contributor

@sbailey sbailey commented Jan 14, 2022

This PR fixes a bug on 20220113 exp 118634 and 118635 where the measured humidity (5.5%) was well outside the fiberflat model humidity range (10-45%) and the chi2 scan wasn't able to sample the real minimum and was picking the wrong model extreme:
Screen Shot 2022-01-14 at 10 58 19 AM

The fix is to just limit the considered humidities to be within 20% of the measured humidity. We can refine that in the future (as well as expand the model as we get more data under very low and high humidity conditions).

Test commands that previously crash and now work:

desi_compute_humidity_corrected_fiberflat --use-sky-fibers -i /global/cfs/cdirs/desi/spectro/redux/daily/exposures/20220113/00118634/frame-b1-00118634.fits --fiberflat /global/cfs/cdirs/desi/spectro/redux/daily/calibnight/20220113/fiberflatnight-b1-20220113.fits -o blat.fits

desi_compute_humidity_corrected_fiberflat --use-sky-fibers -i /global/cfs/cdirs/desi/spectro/redux/daily/exposures/20220113/00118635/frame-b1-00118635.fits --fiberflat /global/cfs/cdirs/desi/spectro/redux/daily/calibnight/20220113/fiberflatnight-b1-20220113.fits -o foo.fits

@sbailey sbailey requested a review from akremin January 14, 2022 19:07
@sbailey sbailey added this to In progress in dailyops via automation Jan 14, 2022
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.0007%) to 25.155% when pulling ecd7faa on fiberflat_humidity into f200339 on master.

Copy link
Member

@akremin akremin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple and effective solution. Changes look good, thank you.

@akremin akremin merged commit cecb094 into master Jan 14, 2022
dailyops automation moved this from In progress to Done Jan 14, 2022
@akremin akremin deleted the fiberflat_humidity branch January 14, 2022 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants