limit humidity model range considered #1594
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug on 20220113 exp 118634 and 118635 where the measured humidity (5.5%) was well outside the fiberflat model humidity range (10-45%) and the chi2 scan wasn't able to sample the real minimum and was picking the wrong model extreme:
The fix is to just limit the considered humidities to be within 20% of the measured humidity. We can refine that in the future (as well as expand the model as we get more data under very low and high humidity conditions).
Test commands that previously crash and now work: