Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad column fibermask #1605

Merged
merged 6 commits into from Jan 21, 2022
Merged

Bad column fibermask #1605

merged 6 commits into from Jan 21, 2022

Conversation

julienguy
Copy link
Contributor

  • Use fibermask bits BADAMPB, BADAMPR, BADAMPZ to flag fibers affected by bad CCD columns instead of using the fibermask bit BADCOLUMN that does not specify the CCD.
  • This avoid having coaddition masked whole spectra when only one camera is affected.
  • Code tested on tile 273 SP5. One Lya quasar that was fully masked in f5 run is now successfully fitted with redrock.

spec3-bis

This addresses issue #1604 .

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.006%) to 25.192% when pulling a03ba2d on bad-column-fibermask into 0d7e5c0 on master.

@sbailey
Copy link
Contributor

sbailey commented Jan 20, 2022

I confirm that for this tile petal, the only targets with significant changes were previously COADD_FIBERSTATUS=BADCOLUMN and are now COADD_FIBERSTATUS=BADAMPR or BADAMPZ, with 1/3 of the spectrum masked instead of all of the spectrum masked, at least making it possible for redrock to fit a redshift.

However, I think we should consider also setting a redrock ZWARN bit (perhaps LITTLE_COVERAGE?) for these cases, since they are fundamentally different from normal 3-camera data in that there are large ranges of redshifts for which we couldn't correctly fit an ELG. This is similar to how we propagate fiberstatus POORPOSITION and BADPOSITION into zwarn POORDATA and NODATA instead of requiring end-users to inspect both masks. That's a change on the redrock side, to be coordinated with this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants