handle missing cframe in tsnr2 summing #1665
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a simple suggested fix for issue #1664.
I let @julienguy review.
My understanding is that for each fiber of a given petal, we get the TSNR2 with summing the values over the three cameras, i.e.: TSNR2 = TSNR2_ELG_B+TSNR2_ELG_R+TSNR2_ELG_Z (using ELG here)
desispec/py/desispec/exposure_qa.py
Lines 305 to 312 in 769b712
(
entries
are the 500 indexes of the fibers for the considered petal).This fix will just ignore a camera if the cframe file is missing.
In the issue case (z-camera missing for petal=7), we will have for petal=7: TSNR2 = TSNR2_ELG_B+TSNR2_ELG_R, and this will result in a lower efftime:
Is that what we want?