New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
specmask.BADFIBER #1674
specmask.BADFIBER #1674
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can ignore these comments if you wish, but it naively looks to me like you are ignoring amplifier bits on the actual cameras for which they apply, which I'd like more explanation on.
(retesting code before committing after accounting for Anthony's comments) |
…use function argument and not 'b' for stdstar fiberbitmasking
@akremin the code ready for second review. I checked it's producing the expected results (good redshifts despite lack of r-camera data for some fibers)
|
The updates addressed my comments. I made a doc string update to clarify that multiple bands are acceptable. |
This PR fixes a bug/feature in the
fiberbitmask
functions, where thespecmask.BADFIBER
bit was set in theframe.mask
whenever afibermask.BADAMP{B,R,Z}
bit was set in thefibermap['FIBERSTATUS']
, irrespectively of the frame camera.As an example, with the change in this PR, the quasar spectra from SP1 in tile 1299 are recovered.
See https://data.desi.lbl.gov/desi/spectro/redux/jguy/tiles/pernight/1299/20210707/tile-qa-1299-20210707.png
compared to https://data.desi.lbl.gov/desi/spectro/redux/guadalupe/tiles/pernight/1299/20210707/tile-qa-1299-20210707.png
This PR fixes issue #1673