Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix plot_spectra astropy 5 table masking #1695

Merged
merged 1 commit into from Feb 17, 2022
Merged

fix plot_spectra astropy 5 table masking #1695

merged 1 commit into from Feb 17, 2022

Conversation

sbailey
Copy link
Contributor

@sbailey sbailey commented Feb 17, 2022

This PR fixes #1693 where plot_spectrum is broken due to astropy 5 auto-masking of table inputs. This uses the desispec.io.read_table wrapper instead so that blank strings just remain blank strings.

This case now works again:

cd /global/cfs/cdirs/desi/spectro/redux/daily/tiles/cumulative/20140/20211117/
plot_spectra -i coadd-0-20140-thru20211117.fits -t 39627438107395133 --redrock redrock-0-20140-thru20211117.fits

@sbailey sbailey added the crash label Feb 17, 2022
@sbailey sbailey added this to In progress in Fuji via automation Feb 17, 2022
@coveralls
Copy link

Coverage Status

Coverage remained the same at 24.861% when pulling abab6ef on plotcrash5 into bc840bb on fuji.

@sbailey sbailey merged commit 49b2a69 into fuji Feb 17, 2022
Fuji automation moved this from In progress to Done Feb 17, 2022
@sbailey sbailey deleted the plotcrash5 branch February 17, 2022 23:48
@sbailey sbailey mentioned this pull request Feb 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
crash
Projects
Fuji
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sbailey @coveralls