add SPGRPVAL to desi_zcatalog output for custom coadds/redshifts #1712
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR propagates the input SPGRPVAL header keywords into the desi_zcatalog output ZCATALOG tables. For the perexp, pernight, and cumulative groups this is redundant with EXPID, NIGHT, and LASTNIGHT columns, but for custom coadds like 1x_depth, 4x_depth, lowspeed it provides a generic way to record which input set contributed to each row.
Example outputs are in /global/cfs/cdirs/desi/users/sjbailey/dev/fuji/zcat:
The one future-proofing trick is that it tries to use np.int32 as the dtype if it can (applies to all current cases of SPGRPVAL), otherwise falling back to np.int64 or letting numpy derive the dtype if not an int.
@rongpu @akremin comments?
Note: we may have other PRs soon for zcatalog to patch missing targeting info, etc. but I'm trying to keep each feature in a separate PR.