fix desi_proc stdstars args #1822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This 2-character PR fixes #1816 where @paulmartini reported a bug with the desi_proc call to stdstars.main and correctly identified the fix. I independently verified that it works by processing a real data exposure; Paul had previously verified that it worked on a simulated exposure. I plan to self merge after tests pass since this is effectively a review of what Paul had already suggested and tested.
For context, the standard pipeline uses a joint fit across exposures for the standard star step, and thus we had missed testing this case of single-exposure stdstar fitting. Thanks for catching it and reporting the fix.