Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix fallback to DESI_SPECTRO_CALIB if DESI_SPECTRO_DARK is set and no suitable files found #1882

Merged
merged 1 commit into from Oct 24, 2022

Conversation

Waelthus
Copy link
Contributor

This fixes #1880 by falling back to DESI_SPECTRO_CALIB in cases where no suitable darks are found in DESI_SPECTRO_DARK.

@Waelthus Waelthus requested a review from sbailey October 24, 2022 09:52
@sbailey
Copy link
Contributor

sbailey commented Oct 24, 2022

Thanks for the quick fix, I'll merge this now so that we can proceed, but in the near term let's get DESI_SPECTRO_DARK completely self-sufficient for DARKs covering the full time range, even if that means copying darks from DESI_SPECTRO_CALIB into DESI_SPECTRO_DARK to cover the earlier time period. i.e. we should aim to deprecate all biases and darks in DESI_SPECTRO_CALIB so that DESI_SPECTRO_DARK is the complete and authoritative source of those.

@sbailey sbailey merged commit b8ce962 into main Oct 24, 2022
@sbailey sbailey deleted the fix_desi_spectro_dark branch November 9, 2022 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

find_darks_in_desi_spectro_dark crash on 20201214
2 participants