apply timefactor scaling to nightlyflat too #1898
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nightlyflat jobs were getting a runtime limit of 5 minutes, which is borderline for KNL on bad I/O days. Most job types get an additional timefactor scaling (3 in the case of KNL) to acknowledge that some systems are faster than others. Previously nightlyflat and arc jobs were excluded from this. For arcs that was to avoid ridiculously long job timelimit requests, while just accepting occasional timeouts and resubmissions. It's unclear why nightlyflat was also previously excluded.
This PR re-enables timefactor scaling for nightlyflat jobs, which results in 15 minute requests on KNL, which is still short-enough and a comfortable overhead to the typical 5 minutes runtime. We may not use KNL for productions ever again, but a few test jobs are still using it for some comparisons and this would be handy to have.