coadd cosmics_nsig default cleanup #1906
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves "ownership" of the coadd cosmics_nsig=4.0 default from individual scripts into the
desispec.coaddition.coadd()
function itself. Previouslydesispec.scripts.coadd_spectra
had an argparse default of 4.0, whiledesispec.scripts.group_spectra
used the different default (0.0) fromdesispec.coaddition.coadd
, resulting in coaddition differences fromdesi_group_spectra ... --coaddfile coadd.fits
vs.desi_coadd_specra ... --outfile coadd.fits
.This PR is into the desi_zproc branch (not main) because it is needed for final verification testing that that branch produces the same answer with refactored script workflow.
Tested with:
data are identical; headers differ due to timestamps and input filenames.