poststd can't fit more cams than stdstar did #1916
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug discovered on 20221121, where z7 was bad but b7 and r7 were still good. The stdstar jobs were excluding sp7, but the poststdstar jobs were still trying to include b7 and r7 and failing since stdstar-7-*.fits didn't exist. It's unclear to me whether this is a new bug, or whether in the past we flagged all cameras of a spectrograph as bad if any of them were bad since we knew we couldn't get to redshifts for that spectrograph anyway (I have some vague memory of that hack...)
This PR fixes it by checking the PROCCAMWORD of each poststdstar job and making sure that it doesn't exceed the cameras included in its corresponding stdstar job.
I have not tested whether we have a similar bug in use-tilenight, but since that follows a different logic flow it may not. This is being tested in-situ on the 20221119 daily processing using this branch, and so far so good...
Note: this PR is into the "daily" branch, and then we'll merge that back into main.