Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create_sframesky_pdf(): display IVAR=0 pixels in yellow #1926

Merged
merged 1 commit into from Dec 2, 2022
Merged

Conversation

araichoor
Copy link
Contributor

This PR highlights IVAR=0 pixels in the sframesky-NIGHT.pdf plots in the the night qa.

I picked the yellow color, so that it does not attract too much the eye.

For instance for EXPID=154146 on 20221121, where b8 is flagged:

Current:
Screenshot 2022-12-01 at 11 38 11 AM

With this PR:
Screenshot 2022-12-01 at 11 38 25 AM

I am wondering if I should go for something a bit more fancier, with rather overplotting with transparency the yellow thing, so that one would still see the masked features (here b8), at the risk of losing in readibility...

any suggestion is welcome!

@araichoor
Copy link
Contributor Author

mmhh some test fails, on something unrelated to this PR, I think:

FAILED py/desispec/test/test_linalg.py::TestLinalg::test_cholesky_invert - AssertionError: 1.2767227175480552e-07 != 0.0 within 7 places (1.2767227175480552e-07 difference)

@sbailey
Copy link
Contributor

sbailey commented Dec 2, 2022

Thanks @araichoor . Overplotting with transparency to see the features that were masked could be neat but might take some time and tuning to get right, so let's take this improvement as-is and save further tuning for the future if we need it.

@sbailey sbailey merged commit 2977f89 into daily Dec 2, 2022
@sbailey sbailey deleted the nightqa_v14 branch December 2, 2022 05:01
sbailey added a commit that referenced this pull request Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants