Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not set ivar=0 to UNASSIGNED fibers by default #1942

Merged
merged 1 commit into from Dec 21, 2022

Conversation

julienguy
Copy link
Contributor

Do not set ivar=0 to UNASSIGNED fibers by default because they might be useful for some analysis.
This addresses part of desisurveyops issue desihub/desisurveyops#76 .
(The other part being the counterintuitive default values of redrock redshifts for spectra with zero valid data)

@akremin
Copy link
Member

akremin commented Dec 21, 2022

A simple change that will partially solve the referenced issue. This does impact the masking for all pipeline steps, as it was implemented in a lower-level function. I believe this includes coadditions, so if we still want to mask these at the coadd/redshift level then we will have to do that in a future PR. I verified that this shouldn't impact sky modeling, because those are only selected among SKY targets, and this affects UNASSIGNED targets.

@sbailey
Copy link
Contributor

sbailey commented Dec 22, 2022

For the record: redrock uses the fiberstatus UNASSIGNED, BADPOSITION, and BROKENFIBER bits to set the zwarn NODATA bit, so this PR allows the UNASSIGNED fibers to be fit but they will still receive a zwarn flag, which I think is what we want. This is similar to fitting redshifts for SKY fibers but setting the zwarn SKY bit.

Arguably it would be better to set the zwarn BAD_TARGET bit for unassigned fibers, but at least something is being set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants