use desimodel/0.18.0 for testing #1957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test logs confirm that it used scipy/1.10.0 and desimodel/0.18.0 and passed. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates desispec to use desimodel/0.18.0 for testing. This version of desimodel includes an endianness fix for compatibility with scipy/1.10.0 (see desihub/desimodel#164). This is the underlying cause of the test failures in recent PRs (e.g. #1950, which temporarily fixed it by pinning to an older scipy; also #1954 and #1955).
I plan to self-merge as long as tests do indeed use scipy/1.10.0 and pass. After this PR I'll also merge daily -> main to pickup this and other recent updates to daily.