re-allow redrock+GPU on large inputs #1966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akremin
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redrock+GPU used to run out of memory on input files with >1k targets (e.g. large healpix), which we had worked around in zproc by checking the number of targets and falling back to CPU-only on big inputs. desihub/redrock#211 fixed the problem, so this PR removes the ntargets check from zproc. I tested by rerunning himalayas sv3 dark healpix 10152 with 2192 targets and confirming that zproc ran redrock with GPU and that it completed fine.
This PR also fixes a bug where
zproc --batch ...was accidentally forcing--no-gpuunless--mpiwas also specified.