Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove imports from deprecated scipy.ndimage.filters namespace #1977

Merged
merged 2 commits into from Jan 24, 2023

Conversation

moustakas
Copy link
Member

Unit tests have myriad deprecation warnings of the sort:

/home/runner/work/desispec/desispec/py/desispec/preproc.py:14: DeprecationWarning: 
Please use `median_filter` from the `scipy.ndimage` namespace, the `scipy.ndimage.filters` 
namespace is deprecated.
    from scipy.ndimage.filters import median_filter

https://github.com/desihub/desispec/actions/runs/3919211294/jobs/6700069463#step:5:65

The scipy.ndimage.filters namespace was deprecated as far back as scipy/0.19.1 (I think), so I didn't bother to support both new and old versions.

Copy link
Member

@weaverba137 weaverba137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

@sbailey sbailey merged commit 855757d into main Jan 24, 2023
@sbailey sbailey deleted the filters-deprecated branch January 24, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants